[
https://issues.apache.org/jira/browse/SOLR-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022520#comment-16022520
]
Gethin James commented on SOLR-7871:
------------------------------------
I having been thinking about the general approach. These days external
configuration via env variables or config file is super important. Its great
that you have kept the ability to specify SOLR_INCLUDE or look up the config
file from a series of well known directories.
I like the approach taken in SolrResourceLoader.locateSolrHome which looks for
a property in order, ie. jndi -> system property or default value. Perhaps we
can generalize that approach for configuration, to look for jndi -> system
property -> ENV_VAR or default value?
I didn't think I felt strongly about the actual config file format but I
probably favor yaml. If a yaml file is used instead of solr.conf then text
editors can do highlighting. It's also machine readable / easier to parse. It
can also be versioned, (e.g. docker-compose) where you can move from one
version of the configuration to another whilst still being backwards compatible.
I could probably help out with this in the coming weeks.
> Platform independent config file instead of solr.in.sh and solr.in.cmd
> ----------------------------------------------------------------------
>
> Key: SOLR-7871
> URL: https://issues.apache.org/jira/browse/SOLR-7871
> Project: Solr
> Issue Type: Improvement
> Components: scripts and tools
> Affects Versions: 5.2.1
> Reporter: Jan Høydahl
> Assignee: Jan Høydahl
> Labels: bin/solr
> Fix For: master (7.0)
>
> Attachments: SOLR-7871.patch, SOLR-7871.patch
>
>
> Spinoff from SOLR-7043
> The config files {{solr.in.sh}} and {{solr.in.cmd}} are currently executable
> batch files, but all they do is to set environment variables for the start
> scripts on the format {{key=value}}
> Suggest to instead have one central platform independent config file e.g.
> {{bin/solr.yml}} or {{bin/solrstart.properties}} which is parsed by
> {{SolrCLI.java}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
