[ 
https://issues.apache.org/jira/browse/SOLR-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022619#comment-16022619
 ] 

Jan Høydahl commented on SOLR-7871:
-----------------------------------

If we replaced {{start.jar}} with our own {{startsolr.jar}} then the whole 
command line would look better, i.e. we could use {{-Dsolr.port=8983 
-Dsolr.stop.port=7983}}, and our ugly {{ps -ef}} parsing could be more certain 
that it found a solr process instead of looking for getting false start.jar 
matches etc. But this is for another JIRA.

Feel free [~covolution] to jump in and play with some YAML parsing, var 
mappings, jndi etc.

Perhaps the immediate goals of this issue should be
* Possible to override any setting through env.var (now solr.in.xx wins every 
time)
** This could be committed as a sub task if so be
* If you choose to use the config file it should be on a standard format, not 
platform specific
** The end result from parsing the file could still be as in this patch, that 
all is converted to env.vars that the existing bin/solr scripts already know 
how to parse
* It should be easy for users to map between env.vars and config file keys. And 
if we rename env.vars in this process, perhaps deprecate old version and 
support both for 7.x

> Platform independent config file instead of solr.in.sh and solr.in.cmd
> ----------------------------------------------------------------------
>
>                 Key: SOLR-7871
>                 URL: https://issues.apache.org/jira/browse/SOLR-7871
>             Project: Solr
>          Issue Type: Improvement
>          Components: scripts and tools
>    Affects Versions: 5.2.1
>            Reporter: Jan Høydahl
>            Assignee: Jan Høydahl
>              Labels: bin/solr
>             Fix For: master (7.0)
>
>         Attachments: SOLR-7871.patch, SOLR-7871.patch
>
>
> Spinoff from SOLR-7043
> The config files {{solr.in.sh}} and {{solr.in.cmd}} are currently executable 
> batch files, but all they do is to set environment variables for the start 
> scripts on the format {{key=value}}
> Suggest to instead have one central platform independent config file e.g. 
> {{bin/solr.yml}} or {{bin/solrstart.properties}} which is parsed by 
> {{SolrCLI.java}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to