[ 
https://issues.apache.org/jira/browse/SOLR-8668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16024566#comment-16024566
 ] 

Christine Poerschke commented on SOLR-8668:
-------------------------------------------

Thanks Hoss for taking a look at the working branch vs. master!

bq. ... but I'm guessing that's because an equivilent MergePolicyFactory based 
test already exists?

Correct.

bq. The one thing that jumped out at me is 
SolrIndexConfig.effectiveUseCompoundFileSetting. ...

Good question, I don't recall details right now but will take a look. Thanks 
for flagging it up.

bq. ... Whoa, whoa ... what? ... no, no no! ... -1! ...

Yes, I agree, that logic needs to change. The warning-or-exception pondering 
here preceded the SOLR-10572 clarifications i.e. yes, I agree we must throw an 
exception/fail and actually that will also make the change here easier then 
i.e. no part-1-and-then-part-2 splitting.

> Remove support for <mergePolicy> (in favour of <mergePolicyFactory>)
> --------------------------------------------------------------------
>
>                 Key: SOLR-8668
>                 URL: https://issues.apache.org/jira/browse/SOLR-8668
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Shai Erera
>            Assignee: Christine Poerschke
>            Priority: Blocker
>             Fix For: master (7.0)
>
>         Attachments: SOLR-8668-part1.patch, SOLR-8668-part1.patch
>
>
> Following SOLR-8621, we should remove support for {{<mergePolicy>}} (and 
> related {{<mergeFactor>}} and {{<maxMergeDocs>}}) in trunk/6x.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to