[
https://issues.apache.org/jira/browse/SOLR-8256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16036402#comment-16036402
]
Varun Thacker commented on SOLR-8256:
-------------------------------------
This is not a full review as the patch was pretty big and a lot of it was
seemed fine :)
Here are the few things that I noticed :
- CreateShardCmd: The code which creates all the replicas for the shards around
line 130 : After the patch I don't see we are passing the async param which
means the individual add replica calls will be blocking even if a user
specified async? If my reading of the code is correct it's also bad that no
test failed?
- In places like AbstractDistribZkTestBase etc where we are using
CollectionAdminRequest to create the collection , shards and replicas should we
assert the response to make sure that the action completed without any errors?
- In ZkController Line 1455 I didn't quite understand why this line was
commented out:
{code}// if (c.getRouter() instanceof ImplicitDocRouter) return
true;{code}
- Can we reuse some of the {{publishState}} code already there in OverseerTest ?
> Set legacyCloud=false as default
> --------------------------------
>
> Key: SOLR-8256
> URL: https://issues.apache.org/jira/browse/SOLR-8256
> Project: Solr
> Issue Type: Improvement
> Reporter: Mark Miller
> Priority: Blocker
> Fix For: master (7.0)
>
> Attachments: SOLR-8256.patch, SOLR-8256.patch, SOLR-8256.patch
>
>
> We don't have the old back compat concerns anymore. It's time to remove this
> mostly unknown setting and start defaulting to this behavior that starts us
> down the path of zk=truth.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
