[
https://issues.apache.org/jira/browse/SOLR-8256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16037248#comment-16037248
]
Varun Thacker commented on SOLR-8256:
-------------------------------------
bq. Varun Thacker I did write a test to check for the async of CreateShardCmd
and It returned immediately with a request-id ( I also surprised with this
result )
Like I said you will still get back a response immediately since that's the
code in the collections handler.
But if you don't pass on the async param to a core admin called then that
internally is blocking.
Looking at your new patch and concentrated only on CreateShardCmd . The async
is now being passed however here's the diff of the params that was passed down
before and after the patch :
{code}
ModifiableSolrParams params = new ModifiableSolrParams();
params.set(CoreAdminParams.ACTION,
CoreAdminParams.CoreAdminAction.CREATE.toString());
params.set(CoreAdminParams.NAME, coreName);
params.set(CoreAdminParams.REPLICA_TYPE, typeToCreate.name());
params.set(COLL_CONF, configName);
params.set(CoreAdminParams.COLLECTION, collectionName);
params.set(CoreAdminParams.SHARD, sliceName);
params.set(ZkStateReader.NUM_SHARDS_PROP, numSlices);
ocmh.addPropertyParams(message, params);
{code}
vs
{code}
ZkNodeProps addReplicasProps = new ZkNodeProps(
COLLECTION_PROP, collectionName,
SHARD_ID_PROP, sliceName,
CoreAdminParams.REPLICA_TYPE, typeToCreate.name(),
CoreAdminParams.NODE, nodeName,
CoreAdminParams.NAME, coreName);
if(async!=null) addReplicasProps.getProperties().put(ASYNC, async);
{code}
So why is this very different? We don't we pass PropertyParams for instance?
> Set legacyCloud=false as default
> --------------------------------
>
> Key: SOLR-8256
> URL: https://issues.apache.org/jira/browse/SOLR-8256
> Project: Solr
> Issue Type: Improvement
> Reporter: Mark Miller
> Priority: Blocker
> Fix For: master (7.0)
>
> Attachments: SOLR-8256.patch, SOLR-8256.patch, SOLR-8256.patch,
> SOLR-8256.patch
>
>
> We don't have the old back compat concerns anymore. It's time to remove this
> mostly unknown setting and start defaulting to this behavior that starts us
> down the path of zk=truth.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
