Github user diegoceccarelli commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/202#discussion_r120697530
--- Diff:
solr/contrib/ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java
---
@@ -187,8 +187,8 @@ public String getName() {
}
@Override
- public void setContext(ResultContext context) {
--- End diff --
Hey @m-khl thanks for reviewing my code!
> here is the problem: we have a plenty of transformers they are not
changed? (assuming they shouldn't be. see below)
In the main abstract class I only deprecated `DocTransformer::setContext`,
so they will still compile. I see your point, and I could change so that
`prepare` calls also `setContext`, in this way the behaviour of existing
transformers will be preserved
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
