Github user m-khl commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/202#discussion_r120736862
--- Diff:
solr/core/src/java/org/apache/solr/response/transform/DocTransformers.java ---
@@ -88,4 +89,11 @@ public boolean needsSolrIndexSearcher() {
return false;
}
+ @Override
+ public void finish() {
+ for( DocTransformer a : children ) {
+ a.finish();
--- End diff --
I don't think it a way to design SPI (not A). Such silence should be either
enforced with final/abstract constraints; or enforced in runtime. Imagine if
some good transformer needs finish() to release a resource, but there is some
badass sibling one. and it's enbaled from time-to-time at prod. requests. The
instance will steadily leak, and it would be hard to find out why.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
