[ https://issues.apache.org/jira/browse/LUCENE-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martijn van Groningen updated LUCENE-3099: ------------------------------------------ Attachment: LUCENE-3099.patch Attached a new patch with the discussed changes. The AbstractMatchAllGroupCollector changed a lot. Most code is pushed to implementation classes. During development of fq impl I noticed that the abstraction was still too specific for terms impl. > Grouping module should allow subclasses to set the group key per document > ------------------------------------------------------------------------- > > Key: LUCENE-3099 > URL: https://issues.apache.org/jira/browse/LUCENE-3099 > Project: Lucene - Java > Issue Type: Improvement > Reporter: Michael McCandless > Fix For: 3.2, 4.0 > > Attachments: LUCENE-3099.patch, LUCENE-3099.patch, LUCENE-3099.patch, > LUCENE-3099.patch, LUCENE-3099.patch > > > The new grouping module can only group by a single-valued indexed field. > But, if we make the 'getGroupKey' a method that a subclass could override, > then I think we could refactor Solr over to the module, because it could do > function queries and normal queries via subclass (I think). > This also makes the impl more extensible to apps that might have their own > interesting group values per document. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org