[
https://issues.apache.org/jira/browse/LUCENE-3099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042377#comment-13042377
]
Michael McCandless commented on LUCENE-3099:
--------------------------------------------
I think we are close here! It's great to see you're able to cutover
Solr trunk to the grouping module based on this.
Random things:
* I think we can in fact use Map<...> instead of HashMap<...> in 2nd
pass abstract collector?
* Can you add @SuppressWarnings("unchecked") for the generic array
creations?
* Can you fix the other generics warnings? Eg the copy-ctor in
TopGroups, and TestGrouping has a few warnings. ("ant clean
compile-test" should show all these warnings).
* The class in AllGroupsCollectorTest needs to be renamed
* OK, let's leave groupDocs as protected in the 2nd pass collector
(remove the nocommit/your response).
* For AbstractAllGroupsCollector, can we impl the getGroupCount in
the base class as getGroups.size()?
> Grouping module should allow subclasses to set the group key per document
> -------------------------------------------------------------------------
>
> Key: LUCENE-3099
> URL: https://issues.apache.org/jira/browse/LUCENE-3099
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Michael McCandless
> Fix For: 3.2, 4.0
>
> Attachments: LUCENE-3099.patch, LUCENE-3099.patch, LUCENE-3099.patch,
> LUCENE-3099.patch, LUCENE-3099.patch
>
>
> The new grouping module can only group by a single-valued indexed field.
> But, if we make the 'getGroupKey' a method that a subclass could override,
> then I think we could refactor Solr over to the module, because it could do
> function queries and normal queries via subclass (I think).
> This also makes the impl more extensible to apps that might have their own
> interesting group values per document.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
