After changing that constant check, do you get the same test failures? What
are the actual failure messages?
On Mon, Jun 26, 2017 at 10:38 AM Anshum Gupta <ans...@anshumgupta.net>
wrote:
> Thanks Adrien, sadly, the tests aren't passing. That's the reason why I
> didn't push the changes. I'll see if someone else can help while you're
> away.
>
> -Anshum
>
> On Mon, Jun 26, 2017 at 9:55 AM Adrien Grand <jpou...@gmail.com> wrote:
>
>> Your proposed change looks correct to me. As far as whether other changes
>> are required, I'm currently traveling but can look when I'm back on
>> Thursday. Feel free to push the branches if tests are passing, we can fix
>> things later?
>>
>> Le lun. 26 juin 2017 à 07:13, Anshum Gupta <ans...@anshumgupta.net> a
>> écrit :
>>
>>> The only throw case that I think needs changing is in SegmentInfos.java
>>> L315
>>>
>>> Version luceneVersion = Version.fromBits(input.readVInt(),
>>> input.readVInt(), input.readVInt());
>>> if (luceneVersion.onOrAfter(Version.LUCENE_7_0_0) == false) {
>>> // TODO: should we check indexCreatedVersion instead?
>>> throw new IndexFormatTooOldException(input, "this index is too old
>>> (version: " + luceneVersion + ")");
>>> }
>>>
>>>
>>> The Lucene version here should be LUCENE_7_0_0, instead of the original
>>> LUCENE_6_0_0.
>>>
>>> Is there anything else that's needed (and is this the correct change?).
>>>
>>> -Anshum
>>>
>>>
>>> On Sun, Jun 25, 2017 at 9:45 PM Anshum Gupta <ans...@anshumgupta.net>
>>> wrote:
>>>
>>>> Hi,
>>>>
>>>> I am working on creating the 7x, and 7.0 branches but I have the
>>>> following failing tests:
>>>> [junit4] Tests with failures [seed: 4FBDDCD3F96316D3]:
>>>> [junit4] -
>>>> org.apache.lucene.index.TestSegmentInfos.testVersionsTwoSegments
>>>> [junit4] -
>>>> org.apache.lucene.index.TestSegmentInfos.testIllegalCreatedVersion
>>>> [junit4] -
>>>> org.apache.lucene.index.TestSegmentInfos.testVersionsOneSegment
>>>>
>>>> I assume this is a result of me not doing anything about the following
>>>> TODO that got printed when I ran addVersion.py.
>>>> *TODO*
>>>> * - Update IndexFormatTooOldException throw cases*
>>>>
>>>> Can someone shed more light on what needs to be done here?
>>>>
>>>> -Anshum
>>>>
>>>
