[
https://issues.apache.org/jira/browse/SOLR-10703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070828#comment-16070828
]
ASF GitHub Bot commented on SOLR-10703:
---------------------------------------
Github user diegoceccarelli commented on the issue:
https://github.com/apache/lucene-solr/pull/202
@m-khl I updated the patch, highlights:
1. I removed `prepare` and relied on the old `setContext()`;
2. now a DocTransformer implements Closeable and provides the method
`close()`
3. If a transformer fails it doesn't affect the other trasformers (+
Test)
TODO:
I didn't find a way to check that DocTrasformer::close is always called in
the tests, any idea?
The `close()` is called from `DocsStreamer` so RealTimeGetRequest component
should not be affected by this change, do you think it should?
minor: I think we should rename the Jira item in something like `Make
DocTransformer Closeable` or something like that
> Add prepare() and finish() into DocTransformer
> -----------------------------------------------
>
> Key: SOLR-10703
> URL: https://issues.apache.org/jira/browse/SOLR-10703
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Diego Ceccarelli
> Priority: Minor
> Fix For: master (7.0)
>
>
> This patch adds a {{prepare}} and a {{finish}} method to the interface of
> {{DocTransformer}} allowing a developer to perform actions before/after a doc
> transformer is applied to a result set. My use case was to benchmark the
> performance of a transformer, since transformer time is not part of
> {{QTime}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
