[
https://issues.apache.org/jira/browse/SOLR-10703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16041298#comment-16041298
]
ASF GitHub Bot commented on SOLR-10703:
---------------------------------------
Github user diegoceccarelli commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/202#discussion_r120697530
--- Diff:
solr/contrib/ltr/src/java/org/apache/solr/ltr/response/transform/LTRFeatureLoggerTransformerFactory.java
---
@@ -187,8 +187,8 @@ public String getName() {
}
@Override
- public void setContext(ResultContext context) {
--- End diff --
Hey @m-khl thanks for reviewing my code!
> here is the problem: we have a plenty of transformers they are not
changed? (assuming they shouldn't be. see below)
In the main abstract class I only deprecated `DocTransformer::setContext`,
so they will still compile. I see your point, and I could change so that
`prepare` calls also `setContext`, in this way the behaviour of existing
transformers will be preserved
> Add prepare() and finish() into DocTransformer
> -----------------------------------------------
>
> Key: SOLR-10703
> URL: https://issues.apache.org/jira/browse/SOLR-10703
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Diego Ceccarelli
> Priority: Minor
> Fix For: master (7.0)
>
>
> This patch adds a {{prepare}} and a {{finish}} method to the interface of
> {{DocTransformer}} allowing a developer to perform actions before/after a doc
> transformer is applied to a result set. My use case was to benchmark the
> performance of a transformer, since transformer time is not part of
> {{QTime}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
