We could compile under 1.6 and have a jenkins (ant) target to check binary 1.5 compatibility -- bytecode versions and std. API calls. This way we could use 1.6, @Override annotations, etc. and still ensure 1.5 support for folks that need it.
So... this is technically doable (read: I'm doing it in HPPC and other projects), but requires some trickery with the build process. If there are no -1's on it, I can provide a patch. Dawid On Fri, Jun 3, 2011 at 2:52 PM, Robert Muir <rcm...@gmail.com> wrote: > sounds good! > > just a word of warning: jenkins compiles with an 'actual java 5 > compiler' and currently some things that will pass such as @Override > on interface, javadocs warnings differ between 5 and 6, etc will still > fail in hudson "differently". > > My idea for this was that if I got Uwe to drink a 34oz beer at lucene > revolution, maybe I could talk him into the idea of us switching over > to java 6 in trunk while he was vulnerable... but we all know what > happened :) > > On Fri, Jun 3, 2011 at 8:41 AM, Dawid Weiss <dawid.we...@gmail.com> wrote: >> I've just committed a boo that failed on javadoc. I _did_ run ant test >> before and Eclipse didn't complain about it (even though I have >> javadoc parsing enabled). Can I propose that we add an aggregator >> target that will aggregate checks happening on jenkins (is there one >> already)? I'm thinking of a dummy target like: >> >> <target name="commit-check" depends="clean, test, javadocs" /> >> >> so that once you run that you can be 99% confident you're not screwing >> something up on the build server. If this sounds good, I'll commit it >> in (add any other things you think should be there). >> >> Dawid >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org >> For additional commands, e-mail: dev-h...@lucene.apache.org >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > For additional commands, e-mail: dev-h...@lucene.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
