[ https://issues.apache.org/jira/browse/SOLR-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jason Gerlowski updated SOLR-7871: ---------------------------------- Attachment: SOLR-7871.patch Ah good. In that case, I've attached my initial stab at the 2-step approach you laid out above. I left out the unit-tests that you included in your patch, but I'm just doing that for now. I didn't want to spend time on unit tests that would change drastically if we decided we didn't like this design. IMO it turned out pretty nicely. Really simplified a lot of the related Java code. If people are ok with this approach, next steps include: - re-write unit tests. - env-var precedence/overriding - default values - Windows support > Platform independent config file instead of solr.in.sh and solr.in.cmd > ---------------------------------------------------------------------- > > Key: SOLR-7871 > URL: https://issues.apache.org/jira/browse/SOLR-7871 > Project: Solr > Issue Type: Improvement > Components: scripts and tools > Affects Versions: 5.2.1 > Reporter: Jan Høydahl > Assignee: Jan Høydahl > Labels: bin/solr > Attachments: SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch, > SOLR-7871.patch > > > Spinoff from SOLR-7043 > The config files {{solr.in.sh}} and {{solr.in.cmd}} are currently executable > batch files, but all they do is to set environment variables for the start > scripts on the format {{key=value}} > Suggest to instead have one central platform independent config file e.g. > {{bin/solr.yml}} or {{bin/solrstart.properties}} which is parsed by > {{SolrCLI.java}}. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org