[
https://issues.apache.org/jira/browse/SOLR-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gerlowski updated SOLR-7871:
----------------------------------
Attachment: SOLR-7871.patch
Attached patch adds in support for environment-variable overriding of solr.conf
files.
One question this patch raises is how we want to treat the
environment-variable-overrides when no config-file is present/specified. If a
user uses the {{solr.conf}} format, I think it's clear that env-var overrides
should be in place. When a user uses {{solr.in.sh}} then back-compatibility
dictates that we probably shouldn't provide env-var overrides. But when no
configuration file is present, it's unclear whether we should choose the old
behavior (no env-overrides) or the new behavior (env-var-overrides).
This patch chooses to provide env-var overrides when no configuration file can
be found. That seemed like a relatively safe decision, since chances are low
that users have environment-variables with matching names in their scope that
they DON'T want passed to Solr. But I'm not attached to this decision at all.
I'm happy to change it if others disagree. Any thoughts [~janhoy].
I'm going to do the default values next, and then move on writing unit tests
(pending any suggestions/change-requests from others). Is there anywhere
specific I should look for defaults to these configuration values? I can use
the values that are commented out in the solr.conf/solr.in.sh/solr.in.cmd files
currently, but I wasn't sure that was right...
> Platform independent config file instead of solr.in.sh and solr.in.cmd
> ----------------------------------------------------------------------
>
> Key: SOLR-7871
> URL: https://issues.apache.org/jira/browse/SOLR-7871
> Project: Solr
> Issue Type: Improvement
> Components: scripts and tools
> Affects Versions: 5.2.1
> Reporter: Jan Høydahl
> Assignee: Jan Høydahl
> Labels: bin/solr
> Attachments: SOLR-7871.patch, SOLR-7871.patch, SOLR-7871.patch,
> SOLR-7871.patch, SOLR-7871.patch
>
>
> Spinoff from SOLR-7043
> The config files {{solr.in.sh}} and {{solr.in.cmd}} are currently executable
> batch files, but all they do is to set environment variables for the start
> scripts on the format {{key=value}}
> Suggest to instead have one central platform independent config file e.g.
> {{bin/solr.yml}} or {{bin/solrstart.properties}} which is parsed by
> {{SolrCLI.java}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
