[ 
https://issues.apache.org/jira/browse/SOLR-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16191871#comment-16191871
 ] 

Erick Erickson edited comment on SOLR-11438 at 10/4/17 11:52 PM:
-----------------------------------------------------------------

A bare sketch of a patch, just enough to show that it's _possible_ get "rf" 
back from deletes. I just mechanically passed replicationTracker to 
cmdDistrib.distribDelete (sometimes) without really understanding what I was 
doing and there are zero tests....

I did note that the processAdd returned rf of 3 when there were 4 replicas, so 
my bit of refactoring may have messed up processAdd. Like I said, this was only 
to see what the level of effort required would be. 

I didn't even run the test suite on this patch BTW.


was (Author: erickerickson):
A bare sketch of a patch, just enough to show that it's _possible_ get "rf" 
back from deletes. I just mechanically passed replicationTracker to 
cmdDistrib.distribDelete (sometimes) without really understanding what I was 
doing and there are zero tests....

I did note that the processAdd returned rf of 3 when there were 4 replicas, so 
my bit of refactoring may have messed up processAdd. Like I said, this was only 
to see if it could be done.

> Solr should return rf when min_rf is specified for delete-by-id and 
> delete-by-query.
> ------------------------------------------------------------------------------------
>
>                 Key: SOLR-11438
>                 URL: https://issues.apache.org/jira/browse/SOLR-11438
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>    Affects Versions: 6.6.1, 7.0, master (8.0)
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>         Attachments: SOLR-11438.patch
>
>
> When we add documents and specify min_rf we get back an rf parameter in the 
> response which is the number of replicas that successfully received the add. 
> However, for delete-by-id or delete-by-query we do not return this data. Is 
> there any harm in it?
> Assigning to myself to track, anyone else who wants it feel free.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to