[
https://issues.apache.org/jira/browse/SOLR-11438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16192230#comment-16192230
]
Erick Erickson commented on SOLR-11438:
---------------------------------------
Hmm, I just found this by accident:
This code in DistributedUpdateProcessor.processAdd:
{{ if (minRf > 1) {
String myShardId = forwardToLeader ? null : cloudDesc.getShardId();
replicationTracker = new RequestReplicationTracker(myShardId, minRf);
}
}}
throws an NPE if you specify min_rf in stand alone mode. Specifying min_rf
doesn't make any _sense_ in stand-alone mode but we can be more graceful about
it. This is even without the hack I attached. There are no safeguards around
dereferencing cloudDesc I think (haven't pursued it much)
> Solr should return rf when min_rf is specified for delete-by-id and
> delete-by-query.
> ------------------------------------------------------------------------------------
>
> Key: SOLR-11438
> URL: https://issues.apache.org/jira/browse/SOLR-11438
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Affects Versions: 6.6.1, 7.0, master (8.0)
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Attachments: SOLR-11438.patch
>
>
> When we add documents and specify min_rf we get back an rf parameter in the
> response which is the number of replicas that successfully received the add.
> However, for delete-by-id or delete-by-query we do not return this data. Is
> there any harm in it?
> Assigning to myself to track, anyone else who wants it feel free.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
