Github user dsmiley commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/288#discussion_r155822251
  
    --- Diff: 
lucene/spatial-extras/src/java/org/apache/lucene/spatial/spatial4j/Geo3dShapeFactory.java
 ---
    @@ -67,6 +74,25 @@ public SpatialContext getSpatialContext() {
         return context;
       }
     
    +  /**
    +   * Set the accuracy for circles.
    +   *
    +   * "Accuracy" is defined as the maximum linear distance between any 
point on the
    +   * surface circle and planes that describe the circle. Therefore on 
WSG84, since the
    +   * radius of earth is 6,371,000 meters, an accuracy of 1e-6 corresponds 
to 6.3 meters.
    +   * For an accuracy of 1.0 meters, the value of 1.6e-7.
    +   *
    +   * The default value is set to 10m (1.6e-6).
    +   *
    +   * Note that accuracy has no effect when the planet model is a sphere. 
In that case circles
    +   * are always fully precise.
    +   *
    +   * @param circleAccuracy the provided accuracy as a linear distance.
    --- End diff --
    
    by "linear distance" do you mean decimal degrees as is used in other parts 
of the Spatial4j API? If so please say "decimal degrees".  If not, perhaps it 
should be in that unit?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to