Github user iverase commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/288#discussion_r155843938
--- Diff:
lucene/spatial-extras/src/java/org/apache/lucene/spatial/spatial4j/Geo3dShapeFactory.java
---
@@ -150,10 +176,21 @@ public Rectangle rect(double minX, double maxX,
double minY, double maxY) {
@Override
public Circle circle(double x, double y, double distance) {
- GeoCircle circle = GeoCircleFactory.makeGeoCircle(planetModel,
- y * DistanceUtils.DEGREES_TO_RADIANS,
- x * DistanceUtils.DEGREES_TO_RADIANS,
- distance * DistanceUtils.DEGREES_TO_RADIANS);
+ GeoCircle circle;
+ if (planetModel.ab == planetModel.c) {
--- End diff --
I think spatial3d is a low level library in that respect, so it shouldn't
have such a method. Karl Wright has the last word, comment would be fine
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
