[
https://issues.apache.org/jira/browse/SOLR-11754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16288596#comment-16288596
]
David Smiley commented on SOLR-11754:
-------------------------------------
I believe ASTC is mostly of historical use but was replaced by SolrTestCaseJ4
but we didn't actually remove the old abstraction. [~yo...@apache.org] you
added SolrTestCaseJ4 in SOLR-1835, although at the time AbstractSolrTestCase
was still independent. Do you agree it's time to remove ASTC?
> Remove AbstractSolrTestCase
> ---------------------------
>
> Key: SOLR-11754
> URL: https://issues.apache.org/jira/browse/SOLR-11754
> Project: Solr
> Issue Type: Test
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Tests
> Reporter: David Smiley
> Assignee: David Smiley
>
> I'm arguing AbstractSolrTestCase should be removed as it's obsoleted by
> SolrTestCaseJ4.
> In SOLR-3911 (back in 2012) Mark made it extend from SolrTestCaseJ4. There
> is really very little in this test class. Some of the methods here are
> duplicated by SolrTestCaseJ4 and thus are completely redundant
> (ignoreException, resetExceptionIgnores, getFile). There haven't been any
> modifications to this class of substance since 2012 either.
> I think we can just outright remove it (no deprecation phase). Anyone still
> using it can trivially switch.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
