[ 
https://issues.apache.org/jira/browse/SOLR-11754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16300394#comment-16300394
 ] 

ASF subversion and git services commented on SOLR-11754:
--------------------------------------------------------

Commit 1a161dc774a2afb74b1985bef55543df953c0f42 in lucene-solr's branch 
refs/heads/branch_7x from [~dsmiley]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1a161dc ]

SOLR-11754: remove AbstractSolrTestCase; use SolrTestCaseJ4 instead.
Also removed SolrExampleTestBase in Solrj-tests.

(cherry picked from commit f354a27)


> Remove AbstractSolrTestCase
> ---------------------------
>
>                 Key: SOLR-11754
>                 URL: https://issues.apache.org/jira/browse/SOLR-11754
>             Project: Solr
>          Issue Type: Test
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: Tests
>            Reporter: David Smiley
>            Assignee: David Smiley
>             Fix For: 7.3
>
>         Attachments: SOLR-11754.patch
>
>
> I'm arguing AbstractSolrTestCase should be removed as it's obsoleted by 
> SolrTestCaseJ4.
> In SOLR-3911 (back in 2012) Mark made it extend from SolrTestCaseJ4.  There 
> is really very little in this test class.  Some of the methods here are 
> duplicated by SolrTestCaseJ4 and thus are completely redundant 
> (ignoreException, resetExceptionIgnores, getFile).  There haven't been any 
> modifications to this class of substance since 2012 either.
> I think we can just outright remove it (no deprecation phase).  Anyone still 
> using it can trivially switch.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to