[ 
https://issues.apache.org/jira/browse/LUCENE-8099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293824#comment-16293824
 ] 

David Smiley commented on LUCENE-8099:
--------------------------------------

+1 to make Lucene easier to use by removing redundant and confusing duplicative 
Query subclasses pertaining to boosting.
Now to your approach...

It should be stated clearly is issues when we make changes to dependencies.  
Here you've made the queries module now depend on the expressions module.  
Consequently, all other modules that depend on the queries module (e.g. 
highlighter) now transitively depend on the expressions module.

Please update this for FunctionScoreQuery: 
org.apache.lucene.search.uhighlight.MultiTermHighlighting#extractAutomata     
Boy it would be nice if we had a Query visiting API -- LUCENE-3041

Is it heavyweight to suggest using the expressions module just to multiply a 
score?  I don't know.  Even if it isn't it seems more complex as a user (to 
me).  Perhaps there could be a convenience method so that there is less we need 
to remember to multiply the score by some value-source?  Or can we simply add 
some score-multiplying value-source?

Maybe BoostQuery could use a bit of Javadoc to mention to the reader that the 
queries module contains FunctionScoreQuery for more advanced boosting than 
constant multiplication.

> Deprecate CustomScoreQuery, BoostedQuery and BoostingQuery
> ----------------------------------------------------------
>
>                 Key: LUCENE-8099
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8099
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>            Priority: Minor
>         Attachments: LUCENE-8099.patch
>
>
> After LUCENE-7998, these three queries can all be replaced by a 
> FunctionScoreQuery.  Using lucene-expressions makes them much easier to use 
> as well.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to