[
https://issues.apache.org/jira/browse/LUCENE-8099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293837#comment-16293837
]
Alan Woodward commented on LUCENE-8099:
---------------------------------------
Thanks for reviewing David
bq. Here you've made the queries module now depend on the expressions module
This is a test dependency only, so it won't affect any downstream modules.
bq. org.apache.lucene.search.uhighlight.MultiTermHighlighting
Will update. And yes, it would make life much easier if we could recurse query
trees...
bq. Is it heavyweight to suggest using the expressions module just to multiply
a score?
DoubleValuesSource had a helper to create sources that used arbitrary functions
when I first committed it, but I removed it a bit later because it messed up
equality tests (essentially, you can't check Java closures for equality). I
think expressions are a good solution? They allow for hashcode/equals tests,
they have a very simple syntax, and they're completely general. My worry about
adding a special score-multiplying source is that then you start to add other
specialised sources, and we end up with the existential horror that is the
queries.function.valuesource package. We could maybe make SimpleBindings more
user friendly in another issue if you think it's still complex.
bq. Maybe BoostQuery could use a bit of Javadoc
Good idea
> Deprecate CustomScoreQuery, BoostedQuery and BoostingQuery
> ----------------------------------------------------------
>
> Key: LUCENE-8099
> URL: https://issues.apache.org/jira/browse/LUCENE-8099
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Alan Woodward
> Assignee: Alan Woodward
> Priority: Minor
> Attachments: LUCENE-8099.patch
>
>
> After LUCENE-7998, these three queries can all be replaced by a
> FunctionScoreQuery. Using lucene-expressions makes them much easier to use
> as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
