Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/304#discussion_r161070053
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessor.java
---
@@ -252,6 +256,7 @@ public void processAdd(AddUpdateCommand cmd) throws
IOException {
/** Computes the timestamp of the next collection given the timestamp of
the one before. */
public static Instant computeNextCollTimestamp(Instant fromTimestamp,
String intervalDateMath, TimeZone intervalTimeZone) {
//TODO overload DateMathParser.parseMath to take tz and "now"
+ // GH: I don't think that's necessary, you can set the TZ on now when
you pass it in?
--- End diff --
True that it's not necessary; it's just a proposed convenience.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
