Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/304#discussion_r161070349
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessor.java
---
@@ -99,6 +101,8 @@
.parseDefaulting(ChronoField.HOUR_OF_DAY, 0)
.parseDefaulting(ChronoField.MINUTE_OF_HOUR, 0)
.parseDefaulting(ChronoField.SECOND_OF_MINUTE, 0)
+ // Setting a timezone here is fine as a default, but generally need
to clone with user's timezone, so that
+ // truncation of milliseconds is consistent.
--- End diff --
As I indicated in a previous comment on JIRA, this comment isn't true. We
deliberately make the formatted collection name *insensitive* to the timezone.
Heck we ought to say that here.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
