[ 
https://issues.apache.org/jira/browse/SOLR-11795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16374707#comment-16374707
 ] 

Uwe Schindler commented on SOLR-11795:
--------------------------------------

About snakeyaml: The Exception handling is broken in multiple ways: 
https://bitbucket.org/asomov/snakeyaml/src/9ffe9d8b2ba4e5eabde045d407799a71997cda20/src/main/java/org/yaml/snakeyaml/introspector/PropertyUtils.java?at=default&fileviewer=file-view-default#PropertyUtils.java-124:151

- Uses e.printStackTrace() -> forbidden, this is not acceptable behaviour of a 
library
- catches only those exceptions, that eclipse autogenerated (of course... this 
is incredible shitty code, sorry!), of curse missing the runtime exceptions 
thrown by Java 9 when illegal access is denied
- does not use AccessController.doPrivileged, so it can never be made safe with 
security manager!

IMHO, the only workaround here (without patching this library) is to install a 
security amnager that explicitely denies deep refelection access to java.beans 
(so at least the secruity exception is catched).

Or much simpler: Get rid of YAML!

> Add Solr metrics exporter for Prometheus
> ----------------------------------------
>
>                 Key: SOLR-11795
>                 URL: https://issues.apache.org/jira/browse/SOLR-11795
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: metrics
>    Affects Versions: 7.2
>            Reporter: Minoru Osuka
>            Assignee: Koji Sekiguchi
>            Priority: Minor
>             Fix For: master (8.0), 7.3
>
>         Attachments: SOLR-11795-2.patch, SOLR-11795-3.patch, 
> SOLR-11795-4.patch, SOLR-11795-5.patch, SOLR-11795-6.patch, 
> SOLR-11795-7.patch, SOLR-11795-8.patch, SOLR-11795-9.patch, 
> SOLR-11795-dev-tools.patch, SOLR-11795.patch, solr-dashboard.png, 
> solr-exporter-diagram.png
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> I 'd like to monitor Solr using Prometheus and Grafana.
> I've already created Solr metrics exporter for Prometheus. I'd like to 
> contribute to contrib directory if you don't mind.
> !solr-exporter-diagram.png|thumbnail!
> !solr-dashboard.png|thumbnail!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to