[ https://issues.apache.org/jira/browse/LUCENE-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385223#comment-16385223 ]
ASF subversion and git services commented on LUCENE-8191: --------------------------------------------------------- Commit 97299ed00699c248fc38465ee1b0eb0bb1561d3d in lucene-solr's branch refs/heads/master from [~rcmuir] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=97299ed ] LUCENE-8191: if a tokenstream has broken offsets, its broken. IndexWriter always checks, so a separate whitelist can't work > merge TestRandomChains "brokenConstructors" list with > "brokenOffsetsConstructors" > --------------------------------------------------------------------------------- > > Key: LUCENE-8191 > URL: https://issues.apache.org/jira/browse/LUCENE-8191 > Project: Lucene - Core > Issue Type: Bug > Reporter: Robert Muir > Priority: Major > Attachments: LUCENE-8191.patch, LUCENE-8191.patch > > > Now that indexwriter checks offsets (LUCENE-7626), there is no difference > between the two: A tokenstream that has brokenoffsets will fail regardless, > only in a harder-to-debug way (e.g. some low level exception from > indexwriter). > So I think we should just merge the two lists to reflect that: if it produces > brokenOffsets, its broken. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org