[
https://issues.apache.org/jira/browse/LUCENE-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16385252#comment-16385252
]
Robert Muir commented on LUCENE-8191:
-------------------------------------
As noted in LUCENE-8192, this boolean actually mixed two concerns (offsets and
graph-offsets).
So its possible we could go back to two lists if we really want. I'm inclined
not to do this: to keep the test simpler with just one blacklist. If the
tokenfilter has bugs (be they offsets bugs OR graph offsets bugs), then it
can't be tested.
> merge TestRandomChains "brokenConstructors" list with
> "brokenOffsetsConstructors"
> ---------------------------------------------------------------------------------
>
> Key: LUCENE-8191
> URL: https://issues.apache.org/jira/browse/LUCENE-8191
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Priority: Major
> Fix For: master (8.0), 7.3
>
> Attachments: LUCENE-8191.patch, LUCENE-8191.patch
>
>
> Now that indexwriter checks offsets (LUCENE-7626), there is no difference
> between the two: A tokenstream that has brokenoffsets will fail regardless,
> only in a harder-to-debug way (e.g. some low level exception from
> indexwriter).
> So I think we should just merge the two lists to reflect that: if it produces
> brokenOffsets, its broken.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
