[
https://issues.apache.org/jira/browse/LUCENE-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058198#comment-13058198
]
Chris Male commented on LUCENE-3272:
------------------------------------
bq. ... contrib, and solr into a module
I'm not sure about the practicalities of consolidating Solr's QPs at the
moment. Most, if not all, are somehow directly tied to Solr's Schema concepts.
That in fact seems to be their advantage since the typing information is
hugely beneficial. With Lucene's FieldType work coming up, maybe some of it
can be offloaded to those. We can also work on inverting the APIs in some
places, providing abstractions in others.
That all said, I'm not afraid of trying.
{quote}
I think most tests only use the QP for convenience, maybe just make a REALLY
REALLY simple MockQueryParser that is basically a String.split() for these
tests for convenience? Then it would analyze the terms and make a boolean
query... anything else more complicated (e.g. phrasequery) could just be
explicitly instantiated?
{quote}
Sounds like a great plan (and a great first step).
> Consolidate Lucene's QueryParsers into a module
> -----------------------------------------------
>
> Key: LUCENE-3272
> URL: https://issues.apache.org/jira/browse/LUCENE-3272
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/queryparser
> Reporter: Chris Male
>
> Lucene has a lot of QueryParsers and we should have them all in a single
> consistent place.
> The following are QueryParsers I can find that warrant moving to the new
> module:
> - Lucene Core's QueryParser
> - AnalyzingQueryParser
> - ComplexPhraseQueryParser
> - ExtendableQueryParser
> - Surround's QueryParser
> - PrecedenceQueryParser
> - StandardQueryParser
> - XML-Query-Parser's CoreParser
> All seem to do a good job at their kind of parsing with extensive tests.
> One challenge of consolidating these is that many tests use Lucene Core's
> QueryParser. One option is to just replicate this class in src/test and call
> it TestingQueryParser. Another option is to convert all tests over to
> programmatically building their queries (seems like alot of work).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
