[
https://issues.apache.org/jira/browse/LUCENE-3272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13058769#comment-13058769
]
Robert Muir commented on LUCENE-3272:
-------------------------------------
single jar, but you can customize: its open source.
Hoss I think you are looking at this the wrong way: this actually makes it way
easier for someone writing a small form factor app that uses no query parser at
all, or their own queryparser, or whatever.
we should do this to make the lucene core smaller, and then you plug in the
modules you need (and maybe only selected parts from them, but thats your call).
I don't think we need to provide X * Y * Z possibilities, nor do we need to
provide 87 jar files.
But, this is just rehashing LUCENE-2323, where we already had this
conversation. I think at the least we should put all these QPs into one place
to make refactoring between them easier. Then we make a smaller amount of code
for these small form factor apps you are so concerned about, with the messy
duplication this is not possible now.
I still stand by my comments in LUCENE-2323, and guess what, turns out I think
I was right.
LUCENE-1938 then refactored one of these queryparsers, removing 4000 lines of
code but keeping the same functionality.
> Consolidate Lucene's QueryParsers into a module
> -----------------------------------------------
>
> Key: LUCENE-3272
> URL: https://issues.apache.org/jira/browse/LUCENE-3272
> Project: Lucene - Java
> Issue Type: Improvement
> Components: modules/queryparser
> Reporter: Chris Male
>
> Lucene has a lot of QueryParsers and we should have them all in a single
> consistent place.
> The following are QueryParsers I can find that warrant moving to the new
> module:
> - Lucene Core's QueryParser
> - AnalyzingQueryParser
> - ComplexPhraseQueryParser
> - ExtendableQueryParser
> - Surround's QueryParser
> - PrecedenceQueryParser
> - StandardQueryParser
> - XML-Query-Parser's CoreParser
> All seem to do a good job at their kind of parsing with extensive tests.
> One challenge of consolidating these is that many tests use Lucene Core's
> QueryParser. One option is to just replicate this class in src/test and call
> it TestingQueryParser. Another option is to convert all tests over to
> programmatically building their queries (seems like alot of work).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
