Simon, I ran "ant precommit" on my Dell 4-core laptop with SSD's, three years old, just an hour ago. 23 minutes. So obviously your mileage varies.
"ant documentation-lint" on just Lucene is much faster, and is within the tolerable zone. Karl On Thu, Apr 26, 2018 at 10:08 AM, David Smiley <david.w.smi...@gmail.com> wrote: > FWIW I have a second machine that I rsync my changes to in order to run > "ant test". I occasionally use it for precommit as well. I wrote a small > script to helps me automate this. Perhaps others here will find this > script useful: > > https://gist.github.com/dsmiley/daff3c978fe234b48a69a01b54ea9914 > > On Thu, Apr 26, 2018 at 9:33 AM Robert Muir <rcm...@gmail.com> wrote: > >> everyone here is collaborating: it causes confusion and takes up other >> people's time when you break the build. I would ask to just run >> precommit before committing. you don't have to sit and watch it, you >> can go work on something else while it runs. >> >> On Thu, Apr 26, 2018 at 9:23 AM, Karl Wright <daddy...@gmail.com> wrote: >> > :-) >> > >> > 25 minutes is an eternity these days, Robert. This is especially true >> when >> > others are collaborating with what you are doing, as was the case >> here. The >> > other approach would be to create a branch, but I've been avoiding that >> on >> > git. >> > >> > "ant documentation-lint" is what I'm looking for, thanks. >> > >> > Karl >> > >> > >> > On Thu, Apr 26, 2018 at 8:21 AM, Robert Muir <rcm...@gmail.com> wrote: >> >> >> >> I don't understand the turnaround issue, why do the commits need to be >> >> rushed in? >> >> There is patch validation recently hooked in to avoid keeping your >> >> computer busy for 25 minutes. >> >> If you are not changing third party dependencies or anything "heavy" >> >> like that you should at least run "ant documentation-lint" from >> >> lucene/ >> >> >> >> >> >> On Thu, Apr 26, 2018 at 8:02 AM, Karl Wright <daddy...@gmail.com> >> wrote: >> >> > How long does precommit take you to run? For me, it's a good 25 >> >> > minutes. >> >> > That really impacts turnaround, which is why I'd love a precommit >> that >> >> > looked only at certain things in the local package I'm dealing with. >> >> > >> >> > Karl >> >> > >> >> > On Thu, Apr 26, 2018 at 6:14 AM, Simon Willnauer >> >> > <simon.willna...@gmail.com> >> >> > wrote: >> >> >> >> >> >> Hey folks, >> >> >> >> >> >> I had to fix several glitches lately that are caught by running >> >> >> precommit. It's a simple step please take the time running `ant >> clean >> >> >> precommit` on top-level. >> >> >> >> >> >> Thanks, >> >> >> >> >> >> Simon >> >> >> >> >> >> ------------------------------------------------------------ >> --------- >> >> >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org >> >> >> For additional commands, e-mail: dev-h...@lucene.apache.org >> >> >> >> >> > >> >> >> >> --------------------------------------------------------------------- >> >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org >> >> For additional commands, e-mail: dev-h...@lucene.apache.org >> >> >> > >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org >> For additional commands, e-mail: dev-h...@lucene.apache.org >> >> -- > Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker > LinkedIn: http://linkedin.com/in/davidwsmiley | Book: http://www. > solrenterprisesearchserver.com >
