Github user m-khl commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/371#discussion_r186444765
  
    --- Diff: 
solr/core/src/java/org/apache/solr/request/json/JsonQueryConverter.java ---
    @@ -69,6 +69,13 @@ private void buildLocalParams(StringBuilder builder, 
Object val, boolean isQPars
                 "Error when parsing json query, expect only one query parser 
here, but found : "+map.keySet());
           }
           String qtype = map.keySet().iterator().next();
    +      String qTypeTrimmed = qtype.trim();
    +      String tagName = null;
    +      if (qTypeTrimmed.startsWith("#")) {
    +        tagName = qTypeTrimmed.substring(1);
    --- End diff --
    
    I suppose it makes more sense to keep hash in tag just to make it more 
noticeable and explicit. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to