Github user m-khl commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/371#discussion_r186445542
--- Diff:
solr/core/src/java/org/apache/solr/request/json/JsonQueryConverter.java ---
@@ -77,7 +84,10 @@ private void buildLocalParams(StringBuilder builder,
Object val, boolean isQPars
if (useSubBuilder) subBuilder = new StringBuilder();
- subBuilder = subBuilder.append("{!").append(qtype).append(' ');;
+ if (tagName != null) {
+ subBuilder.append("{!tag=").append(tagName).append("}");
--- End diff --
I believe it should be quoted to avoid problems with spaces inside of tags.
Also, would you mind to embed tag in the same ```{! }``` qparser, rather
than wrap. I'm afraid of some edgecases.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
