On Wed, May 30, 2018 at 10:18 PM Varun Thacker <va...@vthacker.in> wrote:
> Hi Mark, > > I've started glancing at the the repo and some of the issues you are > addressing here will make things a lot more stable under high loads. I'll > look at it in a little more detail in the coming days. > > The key would be how to isolate the work in desecrate chunks to then go > and make Jiras for. SOLR-12405 is the first thing that caught my eye that's > an isolated jira and can be tackled without the http2 client etc > Yeah, anything that does not depend on the Jetty HttpClient or HTTP/2 can likely be brought in independently. The Http2SolrClient can also come in without HTTP/2 or replacing HttpSolrClient and still offer non blocking IO async as a new HTTP/1.1 capable user client. I guess I have maybe 3 JIRA issues filed - Http2SolrClient w/ Jetty HttpClient, HTTP/2, QOSFilter. That covers the foundation. As I have gained access to these features though, all of a sudden it becomes easier to debug and solve other issues. I also learn and discover by pushing down the road. If I just very slowly put it in piece by piece and tried to pre think out every step, the results would be pretty dreary. I would not be anywhere near the current state or have the same understanding of what still needs to be done. Like SolrCloud originally, the scope of change is just too large for standard procedure. We had to fork that too and the merge back was huge and scary, but also would have only been on master. So I'll do what I can to keep the branch up to date and we will have to pull off bitable pieces, with both HTTP/2 and Jetty HttpClient just being big and invasive no matter what, but almost all for the better :) As soon as anyone is ready to collaborate concretely on code, let me know and I'll finish getting a base set of tests basing and move the branch to Apache. - Mark -- - Mark about.me/markrmiller
