> On 7 Jun 2018, at 14:27, Adrien Grand <jpou...@gmail.com> wrote: > > I read quickly and assumed there was still work left since it was still open, > but if it's merged already it's perfect. I don't have enough background to > know whether SOLR-12438 is safe but I'll trust your judgement.
I left it open because ultimately we want to upgrade to 4.0.2, which we’re unable to do at the moment due to some missing artifacts in Maven repo. It may have been confusing … I’ll close this issue and create a separate one for the next upgrade. I’ll do some beasting of the other patch and if it works ok I’ll commit it by tomorrow. > > Le jeu. 7 juin 2018 à 14:25, Andrzej Białecki > <andrzej.biale...@lucidworks.com <mailto:andrzej.biale...@lucidworks.com>> a > écrit : > Hi Adrien, > > Did you mean SOLR-12438? I pushed SOLR-12445 just before you created a > branch, so it’s already there. However, I upgraded SOLR-12438 to a Bug, > because accidentally some of the responses from that handler were improperly > serialised (as arrays instead of maps). Since this is a fix for a new feature > in 7.4 I think it makes sense to commit this fix too. > > >> On 7 Jun 2018, at 10:31, Adrien Grand <jpou...@gmail.com >> <mailto:jpou...@gmail.com>> wrote: >> >> Hello, >> >> I just pushed a branch_7_4. Please do not push features or enhancements to >> this branch, however it's totally fine to keep pushing bugfixes to it, >> though we should be careful if these fixes are not unlikely to introduce >> other bugs. Andrzej, I see SOLR-12445 is marked as an enhancement in JIRA, >> but it's fine to push it to branch_6_4. >> >> Le mer. 6 juin 2018 à 20:56, Cassandra Targett <casstarg...@gmail.com >> <mailto:casstarg...@gmail.com>> a écrit : >> Oh, OK, I see our disconnect. This week is fine, even if it's on the larger >> side. I just meant if someone *does* have big changes, they should start >> sooner rather than later. IOW, don't wait until next week or later. >> >> (Part of what motivated my message is I saw a comment in an issue earlier >> that said there would be time between 7.4 release and Ref Guide release to >> work on docs - that's what I don't want to happen.) >> >> On Wed, Jun 6, 2018 at 12:48 PM David Smiley <david.w.smi...@gmail.com >> <mailto:david.w.smi...@gmail.com>> wrote: >> Roger; but I don't think this simultaneous release means that ref guide >> edits this week are not welcome? Risky/big changes are not welcome I assume. >> >> On Wed, Jun 6, 2018 at 1:35 PM Cassandra Targett <casstarg...@gmail.com >> <mailto:casstarg...@gmail.com>> wrote: >> Well, I know some people don't update docs with their code changes for >> whatever their reasons are, so I just wanted to remind folks that for 7.2 >> the Ref Guide was released at the same time, and I intend this one to be >> too. Not sure if the goal of merging these release processes was widely >> understood yet, so didn't want to assume and catch people unaware. >> >> On Wed, Jun 6, 2018 at 12:23 PM David Smiley <david.w.smi...@gmail.com >> <mailto:david.w.smi...@gmail.com>> wrote: >> > I'd suggest to anyone holding off on doc edits to try to make some time >> > in the next few days, if possible. >> >> What's the concern? >> >> On Wed, Jun 6, 2018 at 9:57 AM Cassandra Targett <casstarg...@gmail.com >> <mailto:casstarg...@gmail.com>> wrote: >> +1, thanks Adrien. >> >> As with the last release, I plan to produce the Solr Ref Guide RC on the >> same day the 7.4 RC is available, so I'd suggest to anyone holding off on >> doc edits to try to make some time in the next few days, if possible. >> >> On Wed, Jun 6, 2018 at 4:59 AM Adrien Grand <jpou...@gmail.com >> <mailto:jpou...@gmail.com>> wrote: >> +1 >> >> Le mer. 6 juin 2018 à 11:53, Andrzej Białecki >> <andrzej.biale...@lucidworks.com <mailto:andrzej.biale...@lucidworks.com>> a >> écrit : >> Hi Adrien, >> >> I would like to upgrade the metrics library to 3.2.6, which fixes an >> important bug affecting histograms (SOLR-12445). >> >> >>> On 6 Jun 2018, at 08:01, Dawid Weiss <dawid.we...@gmail.com >>> <mailto:dawid.we...@gmail.com>> wrote: >>> >>> +1. Thanks Adrien. >>> >>> >>> On Wed, Jun 6, 2018 at 12:01 AM, Varun Thacker <va...@vthacker.in >>> <mailto:va...@vthacker.in>> wrote: >>>> +1 >>>> >>>> On Tue, Jun 5, 2018 at 1:24 AM, Adrien Grand <jpou...@gmail.com >>>> <mailto:jpou...@gmail.com>> wrote: >>>>> >>>>> Hi all, >>>>> >>>>> We released 7.3 two months ago on April 4th and we accumulated quite a >>>>> number of features, enhancements and fixes that are not released yet, so >>>>> I'd >>>>> like to start working on releasing Lucene/Solr 7.4.0. >>>>> >>>>> I propose to create the 7.4 branch later this week and build the first RC >>>>> early next week if that works for everyone. Please let me know if that are >>>>> bug fixes that we think should make it to 7.4 and might not be ready by >>>>> then. >>>>> >>>>> Adrien >>>> >>>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org >>> <mailto:dev-unsubscr...@lucene.apache.org> >>> For additional commands, e-mail: dev-h...@lucene.apache.org >>> <mailto:dev-h...@lucene.apache.org> >>> >> >> -- >> Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker >> LinkedIn: http://linkedin.com/in/davidwsmiley >> <http://linkedin.com/in/davidwsmiley> | Book: >> http://www.solrenterprisesearchserver.com >> <http://www.solrenterprisesearchserver.com/>-- >> Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker >> LinkedIn: http://linkedin.com/in/davidwsmiley >> <http://linkedin.com/in/davidwsmiley> | Book: >> http://www.solrenterprisesearchserver.com >> <http://www.solrenterprisesearchserver.com/>
