[ https://issues.apache.org/jira/browse/LUCENE-8381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531741#comment-16531741 ]
Nhat Nguyen commented on LUCENE-8381: ------------------------------------- [~simonw] Thanks for your quick feedback. I took another look. The problem is that we can not distinguish between hard-deletes and soft-deletes in SoftDeletesRetentionMergePolicy. This MP brings to live documents that soft-deleted then hard-deleted. We then count those documents as soft-deleted in merging. I attached a test for this. I am not sure if we should fix this or not. > PendingSoftDeletes#onNewReader should adjust soft-delete count > -------------------------------------------------------------- > > Key: LUCENE-8381 > URL: https://issues.apache.org/jira/browse/LUCENE-8381 > Project: Lucene - Core > Issue Type: Bug > Affects Versions: 7.4 > Reporter: Nhat Nguyen > Assignee: Simon Willnauer > Priority: Major > Fix For: master (8.0), 7.5, 7.4.1 > > Attachments: LUCENE-8381.patch, merge-soft-hard-deletes.patch > > > The current PendingSoftDeletes#onNewReader does not handle these two edge > cases correctly. > # If the soft-deletes DV was applied to PendingSoftDeletes already, > newDelCount should be less than the soft delete count recorded in > SegmentInfo. testSoftDeleteWithTryUpdateDocValue trips the newSoftDelCount > assertion. > # If the soft-deleted docs were hard-deleted, we should reduce the > softDelCount in the segmentInfo on a new reader. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org