[ https://issues.apache.org/jira/browse/LUCENE-8381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531876#comment-16531876 ]
Simon Willnauer commented on LUCENE-8381: ----------------------------------------- [~dnhatn] I hacked together something that I think is fixing it. it's pretty hacky maybe we find a better solution? I think it's a bug but it won't bring a deleted document back to live it will just loose the hard delete bit here. I still think we should fix it. > PendingSoftDeletes#onNewReader should adjust soft-delete count > -------------------------------------------------------------- > > Key: LUCENE-8381 > URL: https://issues.apache.org/jira/browse/LUCENE-8381 > Project: Lucene - Core > Issue Type: Bug > Affects Versions: 7.4 > Reporter: Nhat Nguyen > Assignee: Simon Willnauer > Priority: Major > Fix For: master (8.0), 7.5, 7.4.1 > > Attachments: LUCENE-8381.patch, LUCENE-8381.patch, > merge-soft-hard-deletes.patch > > > The current PendingSoftDeletes#onNewReader does not handle these two edge > cases correctly. > # If the soft-deletes DV was applied to PendingSoftDeletes already, > newDelCount should be less than the soft delete count recorded in > SegmentInfo. testSoftDeleteWithTryUpdateDocValue trips the newSoftDelCount > assertion. > # If the soft-deleted docs were hard-deleted, we should reduce the > softDelCount in the segmentInfo on a new reader. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org