[ 
https://issues.apache.org/jira/browse/LUCENE-8306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16547693#comment-16547693
 ] 

Alan Woodward commented on LUCENE-8306:
---------------------------------------

Thanks for the review David!

Re label() : yes, that's a good idea, I'll change it to return the leaf query

Re SloppyPhraseMatcher, you're correct, I found some bugs there.  We can't work 
directly on PhrasePositions because the submatches need to be returned in 
order, although I suppose it might be simpler to just have a sorted array of 
ords.  I'll work something up.

Re TermMatchesIterator.getSubMatches(), I've gone back and forth on this.  One 
the one hand, yes, it's already a leaf, but on the other I think it will be 
simpler for consumers to just assume that the top level matches are for 
intervals and the next level are for terms, so for example you can always call 
getSubMatches() to find individual terms when highlighting.

> Allow iteration over the term positions of a Match
> --------------------------------------------------
>
>                 Key: LUCENE-8306
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8306
>             Project: Lucene - Core
>          Issue Type: New Feature
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>            Priority: Major
>         Attachments: LUCENE-8306.patch, LUCENE-8306.patch, LUCENE-8306.patch
>
>
> For multi-term queries such as phrase queries, the matches API currently just 
> returns information about the span of the whole match.  It would be useful to 
> also expose information about the matching terms within the phrase.  The same 
> would apply to Spans and Interval queries.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to