Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/422#discussion_r204532263 --- Diff: solr/core/src/java/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessor.java --- @@ -262,8 +304,14 @@ private boolean updateParsedCollectionAliases() { return false; } - /** Given the route key, finds the collection. Returns null if too old to go in last one. */ - private String findTargetCollectionGivenTimestamp(Instant docTimestamp) { + /** + * Given the route key, finds the correct collection or returns the most recent collection if the doc + * is in the future. Future docs will potentially cause creation of a collection that does not yet exist + * or an error if they exceed the maxFutureMs setting. + * + * @throws SolrException if the doc is too old to be stored in the TRA + */ + private String findCandidateCollectionGivenTimestamp(Instant docTimestamp, String id) { --- End diff -- Okay I see you changed the semantics; it is now a candidate but wasn't before.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org