Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/422#discussion_r204536711
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessor.java
---
@@ -405,4 +454,56 @@ protected void doClose() {
collection, slice.getName());
}
+ private class Maintainer {
+ private final Instant routeTimestamp;
+ private final String id;
+
+ public Maintainer(Instant routeTimestamp, String id) {
+ this.routeTimestamp = routeTimestamp;
+ this.id = id;
+ }
+
+ public String maintain(String targetCollection) {
--- End diff --
I think the parameter name "targetCollection" is confusing. As I
understand it, this is the assumed head collection name; it's more of a
precondition. Maybe name the var "ifHeadCollName" (plus docs)? Perhaps rename
Maintainer to NextCollectionMaker and it could simply be a Callable or Runnable
or something like that even.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
