Github user barrotsteindev commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/425#discussion_r204860462 --- Diff: solr/core/src/test/org/apache/solr/cloud/BasicZkTest.java --- @@ -150,15 +150,13 @@ public void testBasic() throws Exception { zkController.getZkClient().setData("/configs/conf1/solrconfig.xml", new byte[0], true); // we set the solrconfig to nothing, so this reload should fail - try { + SolrException e = expectThrows(SolrException.class, () -> { ignoreException("solrconfig.xml"); h.getCoreContainer().reload(h.getCore().getName()); - fail("The reloaded SolrCore did not pick up configs from zookeeper"); - } catch(SolrException e) { - resetExceptionIgnores(); - assertTrue(e.getMessage().contains("Unable to reload core [collection1]")); - assertTrue(e.getCause().getMessage().contains("Error loading solr config from solrconfig.xml")); - } + }); + resetExceptionIgnores(); --- End diff -- Perhaps we should try and change it, though we have to make sure some other tests do not depend on this bug.
--- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org