Github user dsmiley commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/416#discussion_r209070656
  
    --- Diff: 
solr/core/src/java/org/apache/solr/response/transform/ChildDocTransformerFactory.java
 ---
    @@ -61,6 +57,13 @@
      */
     public class ChildDocTransformerFactory extends TransformerFactory {
     
    +  public static final String PATH_SEP_CHAR = "/";
    --- End diff --
    
    I don't see why these are declared as Strings and not `char`.  It's clumsy 
later to do `charAt(0)`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to