[
https://issues.apache.org/jira/browse/SOLR-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581324#comment-16581324
]
Erick Erickson commented on SOLR-12625:
---------------------------------------
[~dsmiley] Thanks! A lot of things moved around as I was getting it all to work
and there's cruft laying around, thanks for pointing it out. I'll fix those.
And look at it all again after my eyes rest a bit ;)
The test kind of grew into an ungainly beast. There's a lot of work just to get
the schema in place, then not a lot of code to test. Basically it's:
* use a lot of code setting up a field type for all the kinds of fields I want
to test.
* use a little code to populate a few documents with the data (one weakness is
it's the same data for each doc, I'll look at that).
* spend not much code at all insuring that the fields
** were retrieved from the expected place
** are the values expected
And not I have a better idea what's useful if I ever get time to go forward
with SOLR-10229.
> Combine SolrDocumentFetcher and RetrieveFieldsOptimizer
> -------------------------------------------------------
>
> Key: SOLR-12625
> URL: https://issues.apache.org/jira/browse/SOLR-12625
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Priority: Major
> Attachments: SOLR-12625.patch, SOLR-12625.patch, SOLR-12625.patch
>
>
> We have SolrDocumentFetcher and RetrieveFieldsOptimizer. The
> relationship between the two is unclear at first glance. Using
> SolrDocumentFetcher by itself is (or can be) inefficient.
> WDYT about combining the two? Is there a good reason you would want to
> use SolrDocumentFetcher _instead_ of RetrieveFieldsOptimizer?
> Ideally I'd want to be able to write code like:
> solrDocumentFetcher.fillDocValuesMostEfficiently
> That created an optimizer and "did the right thing".
> Assigning to myself to keep track, but if anyone feels motivated feel free to
> take it over.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
