[ 
https://issues.apache.org/jira/browse/SOLR-12625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16582871#comment-16582871
 ] 

Erick Erickson commented on SOLR-12625:
---------------------------------------

Latest version incorporating David's comments and general clean-up as well as 
_finally_ figuring out that Trie fields are SORTED_SET and Point fields are 
SORTED_NUMERIC and making that adjustment in the test code.

Pending objections, I'll probably commit this this weekend. The test has 
considerable randomization in it, one of the relatively rare problems was 
duplicate values so I also added explicit duplicate values in the fields to 
insure coverage there.

1,000 beast iterations last night and all is well. I'll hit it again tonight 
just in case my "minor cosmetic rearrangements" this morning foo'd something.

 

> Combine SolrDocumentFetcher and RetrieveFieldsOptimizer
> -------------------------------------------------------
>
>                 Key: SOLR-12625
>                 URL: https://issues.apache.org/jira/browse/SOLR-12625
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Major
>         Attachments: SOLR-12625.patch, SOLR-12625.patch, SOLR-12625.patch, 
> SOLR-12625.patch
>
>
> We have SolrDocumentFetcher and RetrieveFieldsOptimizer. The
> relationship between the two is unclear at first glance. Using
> SolrDocumentFetcher by itself is (or can be) inefficient.
> WDYT about combining the two? Is there a good reason you would want to
> use SolrDocumentFetcher _instead_ of RetrieveFieldsOptimizer?
> Ideally I'd want to be able to write code like:
> solrDocumentFetcher.fillDocValuesMostEfficiently
> That created an optimizer and "did the right thing".
> Assigning to myself to keep track, but if anyone feels motivated feel free to 
> take it over.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to