Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r211257783
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java
---
@@ -40,22 +43,52 @@
private static final Iterator<String> ingredientsCycler =
Iterables.cycle(ingredients).iterator();
private static final String[] names = {"Yaz", "Jazz", "Costa"};
private static final String[] fieldsToRemove = {"_nest_parent_",
"_nest_path_", "_root_"};
+ private static final int sumOfDocsPerNestedDocument = 8;
+ private static final int numberOfDocsPerNestedTest = 10;
+ private static boolean useSegments;
+ private static int randomDocTopId = 0;
+ private static String filterOtherSegments;
--- End diff --
minor point: rename `filterOtherSegments` to `fqToExcludeNontestedDocs` and
add a comment explaining *why* we even have non-tested docs -- it's to perturb
the Lucene segments a bit to ensure the transformer works with and without docs
in other segments
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
