Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/416#discussion_r211256948
--- Diff:
solr/core/src/test/org/apache/solr/response/transform/TestChildDocTransformerHierarchy.java
---
@@ -264,7 +309,7 @@ private static Object cleanIndexableField(Object field)
{
}
private static String grandChildDocTemplate(int id) {
- int docNum = id / 8; // the index of docs sent to solr in the
AddUpdateCommand. e.g. first doc is 0
+ int docNum = (id / sumOfDocsPerNestedDocument) %
numberOfDocsPerNestedTest; // the index of docs sent to solr in the
AddUpdateCommand. e.g. first doc is 0
--- End diff --
This is looking kinda complicated now (same for fullNestedDocTemplate).
Does it really matter how the type_s value is chosen exactly? I don't know; I
confess to have glossed over this aspect of the test; I don't get the point. I
wonder if whatever the test is trying to truly test here might be simplified to
go about it in some other means.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
