Github user sigram commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/457#discussion_r222593938
--- Diff:
solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java ---
@@ -420,4 +425,68 @@ public static void ensureRunningJettys(int nodeCount,
int timeoutSeconds) throws
cluster.waitForAllNodes(timeoutSeconds);
}
+
+ static final List<String> AUTH_METRICS_KEYS = Arrays.asList("errors",
"timeouts", "requests", "authenticated",
--- End diff --
I think it would be better to put this whole section in a subclass of
SolrCloudTestCase, eg. SolrCloudAuthTestCase - there are only two tests that
need this stuff but there are hundreds of tests that extend this base class and
don't need this.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
