Github user janhoy commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/457#discussion_r222658500
--- Diff:
solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java ---
@@ -420,4 +425,68 @@ public static void ensureRunningJettys(int nodeCount,
int timeoutSeconds) throws
cluster.waitForAllNodes(timeoutSeconds);
}
+
+ static final List<String> AUTH_METRICS_KEYS = Arrays.asList("errors",
"timeouts", "requests", "authenticated",
--- End diff --
Yep, a separate test base class for auth tests makes sense. Good idea. We
could then push down some other utility methods from the tests as well, I see
some duplication a few places.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
