[
https://issues.apache.org/jira/browse/SOLR-12878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16673477#comment-16673477
]
David Smiley commented on SOLR-12878:
-------------------------------------
Excellent work Tim! Lets not touch Lucene in this issue; okay? Create a
separate LUCENE issue for that if you like. I don't think it's a big deal if
the FieldInfos returned is the same or not provided that it's a fast call.
> FacetFieldProcessorByHashDV is reconstructing FieldInfos on every
> instantiation
> -------------------------------------------------------------------------------
>
> Key: SOLR-12878
> URL: https://issues.apache.org/jira/browse/SOLR-12878
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Facet Module
> Affects Versions: 7.5
> Reporter: Tim Underwood
> Assignee: David Smiley
> Priority: Major
> Labels: performance
> Fix For: 7.6, master (8.0)
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The FacetFieldProcessorByHashDV constructor is currently calling:
> {noformat}
> FieldInfo fieldInfo =
> fcontext.searcher.getSlowAtomicReader().getFieldInfos().fieldInfo(sf.getName());
> {noformat}
> Which is reconstructing FieldInfos each time. Simply switching it to:
> {noformat}
> FieldInfo fieldInfo =
> fcontext.searcher.getFieldInfos().fieldInfo(sf.getName());
> {noformat}
>
> causes it to use the cached version of FieldInfos in the SolrIndexSearcher.
> On my index the FacetFieldProcessorByHashDV is 2-3 times slower than the
> legacy facets without this fix.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
