[
https://issues.apache.org/jira/browse/SOLR-12878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16673499#comment-16673499
]
Tim Underwood commented on SOLR-12878:
--------------------------------------
Sure. What's the next step? Would you like me to squish commits 1 and 2 or
just leave as-is? Should I break out the ReaderWrapper changes from commit 3
or just completely leave out commit 3 for now?
As long as the SlowCompositeReaderWrapper caching of FieldInfos makes it in I'm
happy :) . It would be great for that change to make it in time for 7.6 since
that would make it possible for me to move all of my faceting over to the JSON
facets.
> FacetFieldProcessorByHashDV is reconstructing FieldInfos on every
> instantiation
> -------------------------------------------------------------------------------
>
> Key: SOLR-12878
> URL: https://issues.apache.org/jira/browse/SOLR-12878
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: Facet Module
> Affects Versions: 7.5
> Reporter: Tim Underwood
> Assignee: David Smiley
> Priority: Major
> Labels: performance
> Fix For: 7.6, master (8.0)
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> The FacetFieldProcessorByHashDV constructor is currently calling:
> {noformat}
> FieldInfo fieldInfo =
> fcontext.searcher.getSlowAtomicReader().getFieldInfos().fieldInfo(sf.getName());
> {noformat}
> Which is reconstructing FieldInfos each time. Simply switching it to:
> {noformat}
> FieldInfo fieldInfo =
> fcontext.searcher.getFieldInfos().fieldInfo(sf.getName());
> {noformat}
>
> causes it to use the cached version of FieldInfos in the SolrIndexSearcher.
> On my index the FacetFieldProcessorByHashDV is 2-3 times slower than the
> legacy facets without this fix.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
